Skip to content

Deepcompare keys #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
RiskoZoSlovenska wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Deepcompare keys #194

RiskoZoSlovenska wants to merge 1 commit into from

Conversation

@RiskoZoSlovenska
Copy link
Contributor

@RiskoZoSlovenska RiskoZoSlovenska commented Jun 25, 2023

See #193 (comment) for context.

This PR makes util.deepcompare attempt to compare keys that are tables instead of just giving up right away, so that

assert.are.same({ [{}] = 1 }, { [{}] = 1 })

passes.

@RiskoZoSlovenska RiskoZoSlovenska mentioned this pull request Jun 25, 2023
Closed
@Tieske
Copy link
Member

Tieske commented Jun 28, 2023 •
edited
Loading

discussion in #193 , hence locking discussion here

@lunarmodules lunarmodules locked and limited conversation to collaborators Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RiskoZoSlovenska @Tieske